#8 update dataset to conform version 0.3.0

已合并
sprenger 2 年之前 将 6 次代码提交从 LamineCisse/ModifyColname合并至 NeuralEnsemble/master

modification to conform version 0.3.0 BEP:

  • channel_type added in channel.tsv for ephys-nix file

  • add PowerLineFrequencyUnit in ephys-json for ephys_nwb_petersen file

  • add PowerLineFrequency and PowerLineFrequencyUnit in ephys-json for ephys_nix file

  • change task_id to task_name for ephys-nix file

modification to conform version 0.3.0 BEP: - channel_type added in channel.tsv for ephys-nix file - add PowerLineFrequencyUnit in ephys-json for ephys_nwb_petersen file - add PowerLineFrequency and PowerLineFrequencyUnit in ephys-json for ephys_nix file - change task_id to task_name for ephys-nix file
Cisse Mouhamadou Lamine 评论于 2 年之前
发布者

rename tasks_id to task_name in tasks.tsv

rename tasks_id to task_name in tasks.tsv
sprenger 评论于 2 年之前
所有者

Hi @LamineCisse! You still have an additional 'Unnamed: 27' column header in sub-i_ses-140703_task-r2g_run-001_channels.tsv. Could you remove this?

Hi @LamineCisse! You still have an additional 'Unnamed: 27' column header in `sub-i_ses-140703_task-r2g_run-001_channels.tsv`. Could you remove this?
sprenger 评论于 2 年之前
所有者

Hi @LamineCisse! Thanks for also adding the PowerLineFrequency information. However, it seems like you unintentionally added some commata in the ephys_nix/*/_ephys.json files. Do see them?

Hi @LamineCisse! Thanks for also adding the PowerLineFrequency information. However, it seems like you unintentionally added some commata in the ephys_nix/**/*_ephys.json files. Do see them?
sprenger 评论于 2 年之前
所有者

Also it would be good if you could update the name and description of this PR to resemble the current set of changes you propose in here.

Also it would be good if you could update the name and description of this PR to resemble the current set of changes you propose in here.
Cisse Mouhamadou Lamine 评论于 2 年之前
发布者

hi @sprenger, all changes are made now.

hi @sprenger, all changes are made now.
Cisse Mouhamadou Lamine 评论于 2 年之前
发布者

hi @sprenger, all changes are made now.

hi @sprenger, all changes are made now.
sprenger 评论于 2 年之前
所有者

Hi again @LamineCisse, I can't automatically merge your PR, as for some reason your branch is create on the second-latest commit in the master branch and not the latest one. This means you will need to rebase your branch.

Hi again @LamineCisse, I can't automatically merge your PR, as for some reason your branch is create on the second-latest commit in the master branch and not the latest one. This means you will need to rebase your branch.
sprenger 评论于 2 年之前
所有者

Thanks for fixing the branch history! I will merge this.

Thanks for fixing the branch history! I will merge this.
该合并请求已经成功合并!
登录 并参与到对话中。
未选择标签
未选择里程碑
未指派成员
2 名参与者
正在加载...
取消
保存
这个人很懒,什么都没留下。