#8 update dataset to conform version 0.3.0

Merged
sprenger merged 6 commits from LamineCisse/ModifyColname into NeuralEnsemble/master 2 år sedan

modification to conform version 0.3.0 BEP:

  • channel_type added in channel.tsv for ephys-nix file

  • add PowerLineFrequencyUnit in ephys-json for ephys_nwb_petersen file

  • add PowerLineFrequency and PowerLineFrequencyUnit in ephys-json for ephys_nix file

  • change task_id to task_name for ephys-nix file

modification to conform version 0.3.0 BEP: - channel_type added in channel.tsv for ephys-nix file - add PowerLineFrequencyUnit in ephys-json for ephys_nwb_petersen file - add PowerLineFrequency and PowerLineFrequencyUnit in ephys-json for ephys_nix file - change task_id to task_name for ephys-nix file
Cisse Mouhamadou Lamine kommenterad 2 år sedan
Skapare

rename tasks_id to task_name in tasks.tsv

rename tasks_id to task_name in tasks.tsv
sprenger kommenterad 2 år sedan
Ägare

Hi @LamineCisse! You still have an additional 'Unnamed: 27' column header in sub-i_ses-140703_task-r2g_run-001_channels.tsv. Could you remove this?

Hi @LamineCisse! You still have an additional 'Unnamed: 27' column header in `sub-i_ses-140703_task-r2g_run-001_channels.tsv`. Could you remove this?
sprenger kommenterad 2 år sedan
Ägare

Hi @LamineCisse! Thanks for also adding the PowerLineFrequency information. However, it seems like you unintentionally added some commata in the ephys_nix/*/_ephys.json files. Do see them?

Hi @LamineCisse! Thanks for also adding the PowerLineFrequency information. However, it seems like you unintentionally added some commata in the ephys_nix/**/*_ephys.json files. Do see them?
sprenger kommenterad 2 år sedan
Ägare

Also it would be good if you could update the name and description of this PR to resemble the current set of changes you propose in here.

Also it would be good if you could update the name and description of this PR to resemble the current set of changes you propose in here.
Cisse Mouhamadou Lamine kommenterad 2 år sedan
Skapare

hi @sprenger, all changes are made now.

hi @sprenger, all changes are made now.
Cisse Mouhamadou Lamine kommenterad 2 år sedan
Skapare

hi @sprenger, all changes are made now.

hi @sprenger, all changes are made now.
sprenger kommenterad 2 år sedan
Ägare

Hi again @LamineCisse, I can't automatically merge your PR, as for some reason your branch is create on the second-latest commit in the master branch and not the latest one. This means you will need to rebase your branch.

Hi again @LamineCisse, I can't automatically merge your PR, as for some reason your branch is create on the second-latest commit in the master branch and not the latest one. This means you will need to rebase your branch.
sprenger kommenterad 2 år sedan
Ägare

Thanks for fixing the branch history! I will merge this.

Thanks for fixing the branch history! I will merge this.
This pull request has been merged successfully!
Logga in för att delta i denna konversation.
Ingen Etikett
Ingen Milsten
Ingen förvärvare
2 Deltagare
Laddar...
Avbryt
Spara
Det finns inget innehåll än.