#8 update dataset to conform version 0.3.0

Samengevoegd
sprenger heeft 6 commits samengevoegd van LamineCisse/ModifyColname naar NeuralEnsemble/master 2 jaren geleden

modification to conform version 0.3.0 BEP:

  • channel_type added in channel.tsv for ephys-nix file

  • add PowerLineFrequencyUnit in ephys-json for ephys_nwb_petersen file

  • add PowerLineFrequency and PowerLineFrequencyUnit in ephys-json for ephys_nix file

  • change task_id to task_name for ephys-nix file

modification to conform version 0.3.0 BEP: - channel_type added in channel.tsv for ephys-nix file - add PowerLineFrequencyUnit in ephys-json for ephys_nwb_petersen file - add PowerLineFrequency and PowerLineFrequencyUnit in ephys-json for ephys_nix file - change task_id to task_name for ephys-nix file

rename tasks_id to task_name in tasks.tsv

rename tasks_id to task_name in tasks.tsv
sprenger reageerde 2 jaren geleden
Eigenaar

Hi @LamineCisse! You still have an additional 'Unnamed: 27' column header in sub-i_ses-140703_task-r2g_run-001_channels.tsv. Could you remove this?

Hi @LamineCisse! You still have an additional 'Unnamed: 27' column header in `sub-i_ses-140703_task-r2g_run-001_channels.tsv`. Could you remove this?
sprenger reageerde 2 jaren geleden
Eigenaar

Hi @LamineCisse! Thanks for also adding the PowerLineFrequency information. However, it seems like you unintentionally added some commata in the ephys_nix/*/_ephys.json files. Do see them?

Hi @LamineCisse! Thanks for also adding the PowerLineFrequency information. However, it seems like you unintentionally added some commata in the ephys_nix/**/*_ephys.json files. Do see them?
sprenger reageerde 2 jaren geleden
Eigenaar

Also it would be good if you could update the name and description of this PR to resemble the current set of changes you propose in here.

Also it would be good if you could update the name and description of this PR to resemble the current set of changes you propose in here.

hi @sprenger, all changes are made now.

hi @sprenger, all changes are made now.

hi @sprenger, all changes are made now.

hi @sprenger, all changes are made now.
sprenger reageerde 2 jaren geleden
Eigenaar

Hi again @LamineCisse, I can't automatically merge your PR, as for some reason your branch is create on the second-latest commit in the master branch and not the latest one. This means you will need to rebase your branch.

Hi again @LamineCisse, I can't automatically merge your PR, as for some reason your branch is create on the second-latest commit in the master branch and not the latest one. This means you will need to rebase your branch.
sprenger reageerde 2 jaren geleden
Eigenaar

Thanks for fixing the branch history! I will merge this.

Thanks for fixing the branch history! I will merge this.
Dit pull-request is samengevoegd!
Sign in to join this conversation.
Geen label
Geen mijlpaal
Geen verantwoordelijke
2 deelnemers
Laden...
Annuleren
Opslaan
Er is nog geen inhoud.