#12 workarounds for PATH problems on Windows

Closed
opened 3 years ago by seharak · 6 comments

There have been upload issues with Gin globally installed on Windows.

as @achilleas and I have been troubleshooting on some clients, the issue is due to an incompatible OpenSSH client being installed prior to Gin-client installation (now I suspect it is when Matlab gets installed).

  • gin get with incompatible OpenSSH: gin will permanently fail to treat the server as an annex server (Achilleas may be working on a workaround).
  • Clickable scripts with incompatible OpenSSH: upload/download of annexed files will fail even when repository initialization was successful.

What I suggest is:

  1. register GINPATH permanently when the user runs set-global
  2. run path %GINPATH%;%PATH% before the beginning of every script.

By doing so, at the very minimum, the clickable scripts should work. (issues on the command prompt can still persist, though)

There have been upload issues with Gin globally installed on Windows. as @achilleas and I have been troubleshooting on some clients, the issue is due to an incompatible OpenSSH client being installed prior to Gin-client installation (now I suspect it is when Matlab gets installed). - `gin get` with incompatible OpenSSH: gin will permanently fail to treat the server as an annex server (Achilleas may be working on a workaround). - Clickable scripts with incompatible OpenSSH: upload/download of annexed files will fail even when repository initialization was successful. What I suggest is: 1. register `GINPATH` permanently when the user runs `set-global` 2. run `path %GINPATH%;%PATH%` before the beginning of every script. By doing so, at the very minimum, the clickable scripts should work. (issues on the command prompt can still persist, though)
Achilleas Koutsou commented 3 years ago
Owner

Your suggestion made me realise we have another option. I'm thinking maybe a good long term solution (other than the packaging in Anaconda and Chocolatey that we spoke of) might be to have a wrapper script for Windows. The script can be called gin, we can put it anywhere in the user's %PATH% (so it can be placed after a separately installed OpenSSH) but when the script is called, it sets its own path for the GIN dependencies and then runs the command. This way, we only put the script in the user's path, we don't pollute their path with other versions of all the binaries they might already have installed, and the GIN client can use its own dependencies regardless of where they are.

Your suggestion made me realise we have another option. I'm thinking maybe a good long term solution (other than the packaging in Anaconda and Chocolatey that we spoke of) might be to have a wrapper script for Windows. The script can be called `gin`, we can put it anywhere in the user's %PATH% (so it can be placed after a separately installed OpenSSH) but when the script is called, it sets its own path for the GIN dependencies and then runs the command. This way, we only put the script in the user's path, we don't pollute their path with other versions of all the binaries they might already have installed, and the GIN client can use its own dependencies regardless of where they are.
Keisuke Sehara commented 3 years ago
Owner

Sounds nice! I hope that it is relatively simple to realize the idea.

Sounds nice! I hope that it is relatively simple to realize the idea.
Achilleas Koutsou commented 3 years ago
Owner

Here's the PR that implements the idea in my previous comment: https://github.com/G-Node/gin-cli/pull/301

Tested it locally and it seems to work fine.

You can download a development package to test from this repository: https://gin.g-node.org/achilleas/gin-cli-builds

Here's the PR that implements the idea in my previous comment: https://github.com/G-Node/gin-cli/pull/301 Tested it locally and it seems to work fine. You can download a development package to test from this repository: https://gin.g-node.org/achilleas/gin-cli-builds
Keisuke Sehara commented 3 years ago
Owner

Thanks for working with it.

I have recommended some other people to use it (since it is difficult for me to recap the non-working case).

We will see.

Thanks for working with it. I have recommended some other people to use it (since it is difficult for me to recap the non-working case). We will see.
julien colomb commented 3 years ago
Owner

This version should probably be officially released ?

This version should probably be officially released ?
julien colomb commented 3 years ago
Owner

version released

version released
Sign in to join this conversation.
No Milestone
No assignee
3 Participants
Loading...
Cancel
Save
There is no content yet.