No annexed files are needed as the test files are just 24 kb.
Add test files to address change in headers for Neuraview. This to address python-neo PR #944 https://github.com/NeuralEnsemble/python-neo/pull/944 .
No annexed files are needed as the test files are just 24 kb.
Yes, that's right. With the current gin-cli/git-annex configuration everything except for the README and LICENSE should be handled by git-annex.
@PeterNSteinmetz I have added you as a collaborator to the upstream repository, so can you please test our new contribution guideline and tell us if these work for you?
Yes, that's right. With the current gin-cli/git-annex configuration everything except for the README and LICENSE should be handled by git-annex.
@PeterNSteinmetz I have added you as a collaborator to the upstream repository, so can you please test our new [contribution guideline](https://gin.g-node.org/NeuralEnsemble/ephy_testing_data/src/master/README.md) and tell us if these work for you?
OK, thanks for adding me. A few questions and clarifications in the hopes they may be helpful for the project:
Is it really necessary to be using the gin client when the files are small? The reason I ask is that normally I just use a git GUI client when managing my projects (and a lot of IDEs include git these days, such as PyCharm.) So for me, using a separate gin annexing command is a whole separate step and toolchain I need to use.
If this will be required, that should probably be stated in the guideline also so that is clearer.
OK, thanks for adding me. A few questions and clarifications in the hopes they may be helpful for the project:
1. Is it really necessary to be using the gin client when the files are small? The reason I ask is that normally I just use a git GUI client when managing my projects (and a lot of IDEs include git these days, such as PyCharm.) So for me, using a separate gin annexing command is a whole separate step and toolchain I need to use.
2. If this will be required, that should probably be stated in the guideline also so that is clearer.
I guess the alternative would be to send the files to us and we do the upload, what do you think @samuelgarcia? I can add a corresponding sentence about this option at the end of the contribution guidelines.
I guess the alternative would be to send the files to us and we do the upload, what do you think @samuelgarcia? I can add a corresponding sentence about this option at the end of the contribution guidelines.
So I guess it is necessary to annex the files, even the small ones? If so, I would add language to that effect to the guidelines, namely, that files must be committed using gin.
So I guess it is necessary to annex the files, even the small ones? If so, I would add language to that effect to the guidelines, namely, that files *must* be committed using gin.
OK, so I spoke with Samuel about this and will redo this using the annex. Would suggest noting in the contributors guideline that all files other than the readme and license must be in the annex.
OK, so I spoke with Samuel about this and will redo this using the annex. Would suggest noting in the contributors guideline that all files other than the readme and license *must* be in the annex.
@sprenger I followed the instructions and did gin login, git upload and all seems synced now. Can you verify that files are appropriately in the annex and merge? Or I can merge also I see if that is ok with you.
@sprenger I followed the instructions and did gin login, git upload and all seems synced now. Can you verify that files are appropriately in the annex and merge? Or I can merge also I see if that is ok with you.
For now I took the freedom to create a separate branch with the data file tracked by git-annex. The corresponding PR for comparison is here: #45
Does the new branch / PR work for you?
Hi @PeterNSteinmetz, the data file in your new branch https://gin.g-node.org/NeuralEnsemble/ephy_testing_data/src/neuraviewHeader2 is still tracked by git instead of git annex and also has the same commit id as before. Are you sure you started from a clean master branch for doing the commit to git-annex?
For now I took the freedom to create a separate branch with the data file tracked by git-annex. The corresponding PR for comparison is here: #45
Does the new branch / PR work for you?
@PeterNSteinmetz, I adjusted the contribution guideline to address your comments. Would you please have a look and tell me if think these changes help? See, #46.
@PeterNSteinmetz, I adjusted the contribution guideline to address your comments. Would you please have a look and tell me if think these changes help? See, #46.
sprenger
Add test files to address change in headers for Neuraview. This to address python-neo PR #944 https://github.com/NeuralEnsemble/python-neo/pull/944 .
No annexed files are needed as the test files are just 24 kb.
Hi Peter. I think the plan to put everything in the annex even if it is small. @sprenger: can you confirm this ? Or am I wrong ?
Yes, that's right. With the current gin-cli/git-annex configuration everything except for the README and LICENSE should be handled by git-annex.
@PeterNSteinmetz I have added you as a collaborator to the upstream repository, so can you please test our new contribution guideline and tell us if these work for you?
OK, thanks for adding me. A few questions and clarifications in the hopes they may be helpful for the project:
Is it really necessary to be using the gin client when the files are small? The reason I ask is that normally I just use a git GUI client when managing my projects (and a lot of IDEs include git these days, such as PyCharm.) So for me, using a separate gin annexing command is a whole separate step and toolchain I need to use.
If this will be required, that should probably be stated in the guideline also so that is clearer.
I guess the alternative would be to send the files to us and we do the upload, what do you think @samuelgarcia? I can add a corresponding sentence about this option at the end of the contribution guidelines.
So I guess it is necessary to annex the files, even the small ones? If so, I would add language to that effect to the guidelines, namely, that files must be committed using gin.
OK, so I spoke with Samuel about this and will redo this using the annex. Would suggest noting in the contributors guideline that all files other than the readme and license must be in the annex.
@sprenger I followed the instructions and did gin login, git upload and all seems synced now. Can you verify that files are appropriately in the annex and merge? Or I can merge also I see if that is ok with you.
Hi @PeterNSteinmetz, the data file in your new branch https://gin.g-node.org/NeuralEnsemble/ephy_testing_data/src/neuraviewHeader2 is still tracked by git instead of git annex and also has the same commit id as before. Are you sure you started from a clean master branch for doing the commit to git-annex?
For now I took the freedom to create a separate branch with the data file tracked by git-annex. The corresponding PR for comparison is here: #45
Does the new branch / PR work for you?
@PeterNSteinmetz, I adjusted the contribution guideline to address your comments. Would you please have a look and tell me if think these changes help? See, #46.
New replacement branch seems to be working so closing this. Also added comment about contribution guidelines in that pull request.