#60 Suggestion: increase difficulty to perform a merge request.

On various occasions, I accidentally merged a PR rather than making a simple comment. While I understand this is of course my fault, as the corresponding buttons in the UI are clearly labeled, I could imaging that this mishap may also have happened to others. I see two potential ways in improving the UI to reduce the risk of this happening:

(i) In the PR view, put the comment box before the box asking for the comment of the merge request. In this way, a new comment is entered just below the last comment in the time line, which is arguably more natural. Moreover, when not scrolling down enough, this will ensure that the comment box, and not the merge request comment box, is visible.

and/or

(ii) Require the user to press two buttons to merge a merge request. This would be similar to the behavior of, e.g., github, where a first button opens up the box to enter a merge request comment, and only then the button to merge actually appears.

I am aware that these are no small changes, but maybe there are ways to increase the difficulty in merging a PR that could be implemented.

Hi Michael,

thank you for the feedback and the suggestion!

ad (i) I would rather not change the order of "PR merge box" and "PR comment box". First because the order mirrors github and I would like to keep it that way and second because the "PR comment box" also features the "Close PR" button; if this was more prominently placed, more people would also by mistake close a PR.

ad (ii) this is a suggestion definitely worth investigating and might not be as much overhead since we anyway require the use of CSS and JS.