#7 consistency tests

Open
opened 3 years ago by lucasgautheron · 5 comments

It would be nice to have consistency tests for all the datasets, which could include:

  • ChildProject.validate(ignore_files = True, check_annotations = True) returns no error
  • dates in the metadata can be parsed
  • ages seem coherent (> 0 for all children)
  • make sure that 'ses' lies in 1-5 (or is NAN at worst?)

Can you think of more tests ? Suggestions welcome They should be implemented in a pytest compliant fashion I think.

It would be nice to have consistency tests for all the datasets, which could include: - ChildProject.validate(ignore_files = True, check_annotations = True) returns no error - dates in the metadata can be parsed - ages seem coherent (> 0 for all children) - make sure that 'ses' lies in 1-5 (or is NAN at worst?) Can you think of more tests ? Suggestions welcome They should be implemented in a pytest compliant fashion I think.

We can turn write tests for the import code? So given the raw files, we can correctly run the imports for eaf files for example (though maybe ChildProject.validate does this already?).

We can turn write tests for the import code? So given the raw files, we can correctly run the imports for `eaf` files for example (though maybe `ChildProject.validate` does this already?).
Lucas Gautheron commented 3 years ago
Owner

Hello Sarp,

It's a possibility, though I think the priority is to have tests that make sure that the data are ready to be used;

Here's what it could look like:

https://gin.g-node.org/EL1000/bergelson/src/tests/tests/test_data.py

Hello Sarp, It's a possibility, though I think the priority is to have tests that make sure that the data are ready to be used; Here's what it could look like: https://gin.g-node.org/EL1000/bergelson/src/tests/tests/test_data.py
Lucas Gautheron commented 3 years ago
Owner

In the process of writing consistency tests here:

https://gin.g-node.org/EL1000/tools/src/master/EL1000/tests.py

In the process of writing consistency tests here: https://gin.g-node.org/EL1000/tools/src/master/EL1000/tests.py
Lucas Gautheron commented 3 years ago
Owner

https://gin.g-node.org/EL1000/EL1000/src/main/tests/test_datasets.py

Current state:

=========================== short test summary info ============================
FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/alphen]
FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/bergelson]
FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/elo]
FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/ganek]
FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/kalashnikova]
FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/kidd]
FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/lucid]
FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/lyon]
FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/png2019]
FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/rague]
FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/ramirez-esparza]
FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/swedish]
FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/vandam]
FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/warlaumont]
FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/winnipeg]
FAILED tests/test_datasets.py::test_ses[/scratch2/lgautheron/data/EL1000/kalashnikova]
FAILED tests/test_datasets.py::test_ses[/scratch2/lgautheron/data/EL1000/rague]
FAILED tests/test_datasets.py::test_ses[/scratch2/lgautheron/data/EL1000/swedish]
FAILED tests/test_datasets.py::test_child_language[/scratch2/lgautheron/data/EL1000/alphen]
FAILED tests/test_datasets.py::test_child_language[/scratch2/lgautheron/data/EL1000/kalashnikova]
FAILED tests/test_datasets.py::test_child_language[/scratch2/lgautheron/data/EL1000/png2019]
FAILED tests/test_datasets.py::test_child_language[/scratch2/lgautheron/data/EL1000/ramirez-esparza]
FAILED tests/test_datasets.py::test_child_normative[/scratch2/lgautheron/data/EL1000/png2019]
============= 23 failed, 67 passed, 1 warning in 157.44s (0:02:37) =============
https://gin.g-node.org/EL1000/EL1000/src/main/tests/test_datasets.py Current state: ``` =========================== short test summary info ============================ FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/alphen] FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/bergelson] FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/elo] FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/ganek] FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/kalashnikova] FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/kidd] FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/lucid] FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/lyon] FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/png2019] FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/rague] FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/ramirez-esparza] FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/swedish] FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/vandam] FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/warlaumont] FAILED tests/test_datasets.py::test_annotations[/scratch2/lgautheron/data/EL1000/winnipeg] FAILED tests/test_datasets.py::test_ses[/scratch2/lgautheron/data/EL1000/kalashnikova] FAILED tests/test_datasets.py::test_ses[/scratch2/lgautheron/data/EL1000/rague] FAILED tests/test_datasets.py::test_ses[/scratch2/lgautheron/data/EL1000/swedish] FAILED tests/test_datasets.py::test_child_language[/scratch2/lgautheron/data/EL1000/alphen] FAILED tests/test_datasets.py::test_child_language[/scratch2/lgautheron/data/EL1000/kalashnikova] FAILED tests/test_datasets.py::test_child_language[/scratch2/lgautheron/data/EL1000/png2019] FAILED tests/test_datasets.py::test_child_language[/scratch2/lgautheron/data/EL1000/ramirez-esparza] FAILED tests/test_datasets.py::test_child_normative[/scratch2/lgautheron/data/EL1000/png2019] ============= 23 failed, 67 passed, 1 warning in 157.44s (0:02:37) ============= ```
Lucas Gautheron commented 3 years ago
Owner

This time, including the annotations:

=========================== short test summary info ============================
FAILED tests/test_datasets.py::test_ses[/scratch2/lgautheron/data/EL1000/kalashnikova]
FAILED tests/test_datasets.py::test_ses[/scratch2/lgautheron/data/EL1000/rague]
FAILED tests/test_datasets.py::test_ses[/scratch2/lgautheron/data/EL1000/swedish]
FAILED tests/test_datasets.py::test_child_language[/scratch2/lgautheron/data/EL1000/alphen]
FAILED tests/test_datasets.py::test_child_language[/scratch2/lgautheron/data/EL1000/kalashnikova]
FAILED tests/test_datasets.py::test_child_language[/scratch2/lgautheron/data/EL1000/png2019]
FAILED tests/test_datasets.py::test_child_language[/scratch2/lgautheron/data/EL1000/ramirez-esparza]
FAILED tests/test_datasets.py::test_child_normative[/scratch2/lgautheron/data/EL1000/png2019]
============= 8 failed, 82 passed, 1 warning in 3446.57s (0:57:26) =============
srun: error: puck5: task 0: Exited with exit code 1
This time, including the annotations: ``` =========================== short test summary info ============================ FAILED tests/test_datasets.py::test_ses[/scratch2/lgautheron/data/EL1000/kalashnikova] FAILED tests/test_datasets.py::test_ses[/scratch2/lgautheron/data/EL1000/rague] FAILED tests/test_datasets.py::test_ses[/scratch2/lgautheron/data/EL1000/swedish] FAILED tests/test_datasets.py::test_child_language[/scratch2/lgautheron/data/EL1000/alphen] FAILED tests/test_datasets.py::test_child_language[/scratch2/lgautheron/data/EL1000/kalashnikova] FAILED tests/test_datasets.py::test_child_language[/scratch2/lgautheron/data/EL1000/png2019] FAILED tests/test_datasets.py::test_child_language[/scratch2/lgautheron/data/EL1000/ramirez-esparza] FAILED tests/test_datasets.py::test_child_normative[/scratch2/lgautheron/data/EL1000/png2019] ============= 8 failed, 82 passed, 1 warning in 3446.57s (0:57:26) ============= srun: error: puck5: task 0: Exited with exit code 1 ```
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.