#45 Use git configuration if possible

Open
opened 3 years ago by sprenger · 5 comments
sprenger commented 3 years ago

Currently the configuration of gin-cli permits to define also git (annex) specific parameters, e.g. the condition for adding files to git annex instead of git, see gin-cli configuration. These git (annex) specifications can also performed via git directly, i.e. within .gitattributes (e.g via annex.largefiles). Having two locations for these configurations might lead to inconsistent behaviour when using different tools to work with a gin repository as they might give priority to different configuration files. Maybe it would be best to use the git configuration options also from the gin-cli side to avoid duplication here?

Currently the configuration of gin-cli permits to define also git (annex) specific parameters, e.g. the condition for adding files to git annex instead of git, see [gin-cli configuration](https://gin.g-node.org/G-Node/Info/wiki/GIN+CLI+Config). These git (annex) specifications can also performed via git directly, i.e. within [`.gitattributes`](https://git-annex.branchable.com/git-annex-config/) (e.g via annex.largefiles). Having two locations for these configurations might lead to inconsistent behaviour when using different tools to work with a gin repository as they might give priority to different configuration files. Maybe it would be best to use the git configuration options also from the gin-cli side to avoid duplication here?
Achilleas Koutsou commented 3 years ago
Owner

I was (almost) certain I had a gin-cli GitHub issue about this but it seems I was mistaken.

I agree, gin-cli should read and obey git configurations instead of defining its own.

I was (almost) certain I had a gin-cli GitHub issue about this but it seems I was mistaken. I agree, gin-cli should read and obey git configurations instead of defining its own.
Achilleas Koutsou commented 3 years ago
Owner
GitHub issue: https://github.com/G-Node/gin-cli/issues/302
sprenger commented 3 years ago
Poster

Ok, then should we close this one again or do you want to keep it open as reference for others users?

Ok, then should we close this one again or do you want to keep it open as reference for others users?
Achilleas Koutsou commented 3 years ago
Owner

Keep it as a reference.

Keep it as a reference.
sprenger commented 3 years ago
Poster

Another comment regarding the unification of configuration parameters: I noticed that the exclude configuration of gin-cli behaves differently than the .gitattributes configuration via git annex directly. The gin-cli seems to apply the provided patterns to the complete paths of files, whereas git annex seems to check per file & folder name of the given path. E.g. when excluding config*, the gin-cli does not exclude the file data/config.txt, but plain git annex would.

Another comment regarding the unification of configuration parameters: I noticed that the `exclude` configuration of gin-cli behaves differently than the `.gitattributes` configuration via git annex directly. The gin-cli seems to apply the provided patterns to the complete paths of files, whereas git annex seems to check per file & folder name of the given path. E.g. when excluding `config*`, the gin-cli does not exclude the file `data/config.txt`, but plain git annex would.
Sign in to join this conversation.
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.